feat(cli): add local_smtp config#5333
Merged
Merged
Conversation
Coverage Report for CI Build 26896254154Warning No base build found for commit Coverage: 63.922%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Contributor
Author
|
basically the phase 1 of cc @avallete |
Strengthen the inbucket -> local_smtp backward-compat normalization across both the Go and TypeScript config loaders: - Go: only rebuild the viper when an inbucket section is actually present, and preserve the env-binding options (ExperimentalBindStruct, AutomaticEnv, SUPABASE prefix, env key replacer) on the rebuilt instance so env overrides are not silently dropped. - Go: deep-merge a deprecated [inbucket] section over the [local_smtp] template defaults instead of wholesale replacement, so a partial section keeps the defaults it omits (e.g. enabled = true). - TS: emit a deprecation warning on stderr (matching Go) when [inbucket] or [remotes.*.inbucket] is used, without polluting machine-readable stdout. - Add back-compat tests on both sides covering inbucket-only, partial inbucket, local_smtp precedence, remotes normalization, and warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rename the `inbucket` property to `local_smtp` in the published JSON schema (top-level and the [remotes.*] copy) so editors validating config.toml against https://supabase.com/docs/cli/config.schema.json recognize the new section key. Mirrors the inbucket -> local_smtp rename in packages/config; the inner schema and descriptions are unchanged, matching the source of truth. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The local email server is Mailpit, so the user-facing schema description and documentation link no longer reference the now-renamed "Inbucket". Update the section description to "Enable the local SMTP testing server." and point the link at the Mailpit docs, in both packages/config and the published schema. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jgoux
approved these changes
Jun 23, 2026
pull Bot
pushed a commit
to oogalieboogalie/cli
that referenced
this pull request
Jun 24, 2026
…e#5664) Follow-up to supabase#5333 (the `inbucket` → `local_smtp` config rename). Strengthens the config-schema unit test so the deprecated implementation name cannot creep back into the published schema: the assertion now checks the generated schema case-insensitively (`schemaString.toLowerCase()`), covering descriptions as well as keys — not just the lowercase `inbucket` substring. supabase#5333 already removed the last user-facing `inbucket` references (the section key, plus the schema descriptions/link which now point at the actual local tool, Mailpit). This test makes that invariant durable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
adds
local_smtpas the new preferred config key, keepsinbucketvalid with a deprecation warning and updates the default template to uselocal_smtpwhat's introduced:
local_smtpis now the preferred config/schema key, while existinginbucketconfigs continue to work for now....why
basically this moves the config away from an implementation specific name without breaking existing setups in phase 1 :)
ref